HIVE-29234: Iceberg: Validate HMS REST Catalog Client with OAuth2 #6124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
difin
force-pushed
the
oauth2_rest_catalog_client
branch
from
b200287 to
b5bccec
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
okumin
changed the title
okumin
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Overall, +1
Please follow the addressable advice from SonarQube.
https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6124&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true
I changed the JIRA ticket number in the title because I suspect HIVE-29234 is probably the intended one. Please revert it if I'm wrong
| .replace("OAUTH2_JWKS_URI", getJwksUri()) | ||
| .replace("OAUTH2_CLIENT_ID", OAUTH2_SERVER_ICEBERG_CLIENT_ID) | ||
| .replace("OAUTH2_CLIENT_SECRET", OAUTH2_SERVER_ICEBERG_CLIENT_SECRET) | ||
| // .replace("localhost", "host.docker.internal") |
There was a problem hiding this comment.
Thanks, it was a leftover that I didn't notice, done.
|
|
Thanks for core review, @okumin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added Java integration test for testing HMSRestCatalogClient with Oauth2 mode and changed existing RESCatalog client q-tests (those that use HMS and Gravitino as a server) to use Oauth2.
Why are the changes needed?
To test HMSRestCatalogClient with Oauth2 so that it could be used in production systems.
Does this PR introduce any user-facing change?
No, this PR only adds/updates tests.
How was this patch tested?
New and existing tests.